[lkml]   [2010]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] mac8390: change an error return code and some cleanup, take 4
    On Mon, May 31, 2010 at 11:21,  <> wrote:
    > On Mon, 31 May 2010, David Miller wrote:
    >> This is getting tiring Finn.
    > I agree. My patch addresses all of the criticism of the earlier
    > submissions.
    > To make it plain: there are 25 files or so that use ei_debug. Three of
    > those that now have the KERN_DEBUG printk's suppresed by the DEBUG macro
    > only do so as an apparently unintended side effect of a commit that claims
    > to "implement dynmic debug infrastructure". (Go figure.)
    > Your suggestion to use pr_debug is invoking compile time infrastructure
    > (the DEBUG macro), so it is not in the spirit of this commit, and it is
    > not relevant to any criticism from you or Joe of the earlier submissions.
    > Please apply the patch.

    `pr_debug()' indeed now may generate code if DEBUG is not defined,
    i.e. if CONFIG_DYNAMIC_DEBUG is enabled.
    This is intented for debug infrastructure the user may want to enable later.

    If you want the old behavior, you can use `pr_devel()' instead, which
    only generates code if DEBUG is defined.
    This is intended for debug infrastructure for developers only.

    However, you used `printk(KERN_DEBUG pr_fmt()...)`, which always generates code.
    I'm still not 100% sure that was intentional?



    Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

     \ /
      Last update: 2010-05-31 12:01    [W:0.020 / U:168.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site