lkml.org 
[lkml]   [2010]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, hweight: Fix UML boot crash
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Sun, May 30, 2010 at 11:36:16AM -0700

> On 05/30/2010 10:03 AM, Borislav Petkov wrote:
> > Obviously UML cannot stomach callee reg-saving trickery
> > introduced with d61931d89be506372d01a90d1755f6d0a9fafe2d (x86:
> > Add optimized popcnt variants) and oopses during boot:
> > http://marc.info/?l=linux-kernel&m=127522065202435&w=2
> >
> > Go ahead and fall back to the software hweight* routines on UML.
>
> I actually don't understand why UML can't stomach that... it would work
> exactly the same in userspace as in kernel space. The only thing that I
> can think of is if UML overrides the CFLAGS including the per-file
> CFLAGS, but that would seem to cause all kinds of other issues.
>
> I would also be a lot happier if this was handled in
> <asm/arch_hweight.h> than in <asm/bitops.h>. Finally, if UML really
> can't handle this, then ARCH_HWEIGHT_CFLAGS should be disabled on UML.
>
> This bothers me, because it really feels like something is fundamentally
> broken in UML tryingto track the upstream architecture, and this is just
> a bandage.

First of all, scratch that patch. It is indeed dumb idea to sprinkle UML
special cases in x86 just because they include it.

Which begs the question why _is_ UML sucking in x86 stuff and can anyone
provide us with some sensible reasons? Because if there aren't any, it
is their includes that should be fixed. Let me see what I can do to
redirect hweight stuff properly...

--
Regards/Gruss,
Boris.


\
 
 \ /
  Last update: 2010-05-30 21:43    [from the cache]
©2003-2011 Jasper Spaans