lkml.org 
[lkml]   [2010]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/2] Fix migration races in rmap_walk() V3
    On Mon, May 03, 2010 at 05:33:01PM +0200, Andrea Arcangeli wrote:
    > On Sat, May 01, 2010 at 03:51:10PM +0200, Johannes Weiner wrote:
    > > On Fri, Apr 30, 2010 at 08:28:53PM +0200, Andrea Arcangeli wrote:
    > > > Subject: adapt mprotect to anon_vma chain semantics
    > > >
    > > > From: Andrea Arcangeli <aarcange@redhat.com>
    > > >
    > > > wait_split_huge_page interface changed.
    > > >
    > > > Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
    > > > ---
    > > >
    > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
    > > > --- a/mm/huge_memory.c
    > > > +++ b/mm/huge_memory.c
    > > > @@ -929,7 +929,7 @@ int change_huge_pmd(struct vm_area_struc
    > > > if (likely(pmd_trans_huge(*pmd))) {
    > > > if (unlikely(pmd_trans_splitting(*pmd))) {
    > > > spin_unlock(&mm->page_table_lock);
    > > > - wait_split_huge_page(vma->anon_vma, pmd);
    > > > + wait_split_huge_page(mm, pmd);
    > >
    > > That makes mprotect-vma-arg obsolete, I guess.
    >
    > Well it's needed for flush_tlb_range.

    I must have been blind, sorry for the noise.

    > In mincore_huge_pmd probably we could pass vma->vm_mm instead of
    > vma (as there is not flush_tlb_range), I can change it if you prefer.

    Although not strictly required, it's probably nicer to keep the
    function signatures in this code alike. So everything fine with
    me as it stands :)

    Hannes


    \
     
     \ /
      Last update: 2010-05-04 01:45    [W:0.028 / U:0.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site