lkml.org 
[lkml]   [2010]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] fs: optimize mpage_readpage()
    On Sat, May 29, 2010 at 9:46 PM, Borislav Petkov <bp@alien8.de> wrote:
    > From: Changli Gao <xiaosuo@gmail.com>
    > Date: Sat, May 29, 2010 at 09:26:47PM +0800
    >
    >> Did the compiler warning appear after applying my patch? It doesn't
    >> happen when I testing it.
    >
    > yep, using gcc (Debian 4.4.4-2) 4.4.4 here.
    >
    >> And I don't pass bio to do_mpage_readpage(), but I pass NULL instead.
    >
    > True, but you still need that bio pointer so you might just as well set
    > it to NULL as the original code does.
    >

    I'm using gcc 4.4.3(Gentoo). It's strange. on that line, bio is only
    used as left value. Maybe it is a compiler bug, or you didn't apply my
    patch properly.


    --
    Regards,
    Changli Gao(xiaosuo@gmail.com)
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-29 16:21    [W:0.021 / U:64.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site