lkml.org 
[lkml]   [2010]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] oom-kill: give the dying task a higher priority
* Luis Claudio R. Goncalves <lclaudio@uudg.org> [2010-05-28 00:51:47]:

> @@ -382,6 +382,8 @@ static void dump_header(struct task_struct *p, gfp_t gfp_mask, int order,
> */
> static void __oom_kill_task(struct task_struct *p, int verbose)
> {
> + struct sched_param param;
> +
> if (is_global_init(p)) {
> WARN_ON(1);
> printk(KERN_WARNING "tried to kill init!\n");
> @@ -413,8 +415,9 @@ static void __oom_kill_task(struct task_struct *p, int verbose)
> */
> p->rt.time_slice = HZ;
> set_tsk_thread_flag(p, TIF_MEMDIE);
> -
> force_sig(SIGKILL, p);
> + param.sched_priority = MAX_RT_PRIO-1;
> + sched_setscheduler_nocheck(p, SCHED_FIFO, &param);
> }
>

I would like to understand the visible benefits of this patch. Have
you seen an OOM kill tasked really get bogged down. Should this task
really be competing with other important tasks for run time?

--
Three Cheers,
Balbir


\
 
 \ /
  Last update: 2010-05-28 06:35    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site