Messages in this thread | | | Date | Fri, 28 May 2010 03:45:00 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/6] writeback: initial tracing support |
| |
On Thu, May 27, 2010 at 02:32:33PM -0700, Andrew Morton wrote: > > +#define inode_to_bdi(inode) ((inode)->i_mapping->backing_dev_info) > > Could/should be implemented in C. > > > +/* > > + * We don't actually have pdflush, but this one is exported though /proc... > > + */ > > +int nr_pdflush_threads; > > So this is always zero now? > > We don't want to keep it forever. Add a > printk_once("nr_pdflush_threads is deprecated") when someone reads it, > remove it in 2014.
These two lines are just moved down a bit by the patch, I think any cleanups should be left to separate patches.
| |