lkml.org 
[lkml]   [2010]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC] oom-kill: give the dying task a higher priority
    Date
    Hi

    > oom-killer: give the dying task rt priority (v3)
    >
    > Give the dying task RT priority so that it can be scheduled quickly and die,
    > freeing needed memory.
    >
    > Signed-off-by: Luis Claudio R. Gonçalves <lgoncalv@redhat.com>

    Almostly acceptable to me. but I have two requests,

    - need 1) force_sig() 2)sched_setscheduler() order as Oleg mentioned
    - don't boost priority if it's in mem_cgroup_out_of_memory()

    Can you accept this? if not, can you please explain the reason?

    Thanks.

    >
    > diff --git a/mm/oom_kill.c b/mm/oom_kill.c
    > index 84bbba2..2b0204f 100644
    > --- a/mm/oom_kill.c
    > +++ b/mm/oom_kill.c
    > @@ -266,6 +266,8 @@ static struct task_struct *select_bad_process(unsigned long *ppoints)
    > */
    > static void __oom_kill_task(struct task_struct *p, int verbose)
    > {
    > + struct sched_param param;
    > +
    > if (is_global_init(p)) {
    > WARN_ON(1);
    > printk(KERN_WARNING "tried to kill init!\n");
    > @@ -288,6 +290,8 @@ static void __oom_kill_task(struct task_struct *p, int verbose)
    > * exit() and clear out its resources quickly...
    > */
    > p->time_slice = HZ;
    > + param.sched_priority = MAX_RT_PRIO-10;
    > + sched_setscheduler(p, SCHED_FIFO, &param);
    > set_tsk_thread_flag(p, TIF_MEMDIE);
    >
    > force_sig(SIGKILL, p);
    > --
    > [ Luis Claudio R. Goncalves Bass - Gospel - RT ]
    > [ Fingerprint: 4FDD B8C4 3C59 34BD 8BE9 2696 7203 D980 A448 C8F8 ]
    >



    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-29 06:01    [W:0.029 / U:89.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site