lkml.org 
[lkml]   [2010]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86 cpufreq: Make trace_power_frequency cpufreq driver independent
On Tue, 25 May 2010 14:39:59 +0200
Thomas Renninger <trenn@suse.de> wrote:

> and fix the broken case if a core's frequency depends on others.
>
> trace_power_frequency was only implemented in a rather ungeneric way
> in acpi-cpufreq driver's target() function only.
> -> Move the call to trace_power_frequency to
> cpufreq.c:cpufreq_notify_transition() where CPUFREQ_POSTCHANGE
> notifier is triggered.
> This will support power frequency tracing by all cpufreq drivers
>
> trace_power_frequency did not trace frequency changes correctly when
> the userspace governor was used or when CPU cores' frequency depend
> on each other.
> -> Moving this into the CPUFREQ_POSTCHANGE notifier and pass the cpu
> which gets switched automatically fixes this.


while I'm no great fan of having a second field in the perf structure
for the cpu... I can see that Thomas has a use case where this solves
his issue...

Acked-by: Arjan van de Ven <arjan@linux.intel.com>

--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


\
 
 \ /
  Last update: 2010-05-29 03:43    [W:0.988 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site