lkml.org 
[lkml]   [2010]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv4 01/17] VFS: introduce helpers for the s_dirty flag
    On Fri, May 28, 2010 at 01:23:18PM -0700, Andrew Morton wrote:

    > A more conventional and superior naming scheme is
    > subsystemid_specific_function_identifier(). eg, bio_add_page() instead
    > of add_page_to_bio().
    >
    > So these want to be sb_mark_dirty(), etc.
    >
    > Being very old code written by very yound people, the VFS kinda ignores
    > that convention, but it doesn't hurt to use it for new code.
    >
    > Feel free to ignore me if that's too much of a PITA ;)

    The real issue is that it's almost certainly an overdesign. Let's
    get rid of the bogus uses first and figure out what's happening in
    what remains, OK?

    I have no problems with doing such wrappers, but if we touch every
    place using ->s_dirt anyway, let's at least take a good look at them.

    I'm mostly OK with what had emerged for the final patch in series,
    but...


    \
     
     \ /
      Last update: 2010-05-28 23:17    [W:0.051 / U:0.652 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site