Messages in this thread | | | From | Mike Frysinger <> | Date | Fri, 28 May 2010 02:05:27 -0400 | Subject | Re: [PATCH 1/2 v2] FLAT: split the stack & data alignments |
| |
On Wed, May 26, 2010 at 04:45, Mike Frysinger wrote: > The stack and data have different alignment requirements, so don't force > them to wear the same shoe. Increase the data alignment to match that > which the elf2flt linker script has always been using: 0x20 bytes. Not > only does this bring the kernel loader in line with the toolchain, but > it also fixes a swath of gcc tests which try to force larger alignment > values but randomly fail when the FLAT loader fails to deliver.
btw, a follow up patch might be to move the shared lib identifiers from the start of the data section to the end of it so that the re-aligning isnt necessary (we'd get a 4k page alignment from mmap and such). but i cant seem to figure out how these identifiers are being read/written. otherwise, the fact that we're force aligning to 0x20 bytes means that there is always room for 8 identifiers ... no point in flipping between 1 or 4, at least from this point of view ... -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |