lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/8] intel_idle: create a native cpuidle driver for select intel processors

> ... What happens when an additional CPU is brought online?
> It melts? ;)

With the current driver, processors hot-added after modprobe
will use C1 only, and not use deeper C-states.

Taking online processors offline and bringing them back online
(like we do during suspend) works fine.

> > + dev->cpu = i;
> > + if (cpuidle_register_device(dev)) {
> > + pr_debug(PREFIX "cpuidle_register_device %d failed!\n", i);
> > + free_percpu(intel_idle_cpuidle_devices);
> > + return -EIO;
>
> Should this unregister all the thus-far-registered devices?

yes, that was a bug!

thanks,
Len Brown, Intel Open Source Technology Center



\
 
 \ /
  Last update: 2010-05-28 06:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site