lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] streamline_config.pl: use references rather than copied data structures
    From
    Date
    On Thu, 2010-05-27 at 16:24 +0200, Toralf Förster wrote:

    > Understood and accepted.
    >
    > What's about the following 2 snippets (a trivial typo and an attempt to
    > prevent a possible trap) ? :
    >

    Can you make a proper patch out of this (with signed-off-by as well).
    Also your patches have major whitespace damage. Could you fix your mail
    client.

    Thanks,

    -- Steve

    >
    > diff --git a/scripts/kconfig/streamline_config.pl
    > b/scripts/kconfig/streamline_config.pl
    > index afbd54a..3f54911 100644
    > --- a/scripts/kconfig/streamline_config.pl
    > +++ b/scripts/kconfig/streamline_config.pl
    > @@ -242,7 +242,7 @@ foreach my $makefile (@makefiles) {
    > foreach my $obj (split /\s+/,$objs) {
    > $obj =~ s/-/_/g;
    > if ($obj =~ /(.*)\.o$/) {
    > - # Objects may bes enabled by more than one config.
    > + # Objects may be enabled by more than one config.
    > # Store configs in an array.
    > my @arr;
    >
    >
    >
    > diff --git a/scripts/kconfig/streamline_config.pl
    > b/scripts/kconfig/streamline_config.pl
    > index afbd54a..9726946 100644
    > --- a/scripts/kconfig/streamline_config.pl
    > +++ b/scripts/kconfig/streamline_config.pl
    > @@ -307,7 +307,7 @@ close (LIN);
    > my %configs;
    > foreach my $module (keys(%modules)) {
    > if (defined($objects{$module})) {
    > - @arr = @{$objects{$module}};
    > + my @arr = @{$objects{$module}};
    > foreach my $conf (@arr) {
    > $configs{$conf} = $module;
    > }
    >
    >


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-27 21:55    [W:0.023 / U:2.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site