lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference


Dan Carpenter schrieb:
> On Thu, May 27, 2010 at 02:33:47PM +0200, Julia Lawall wrote:
>> If it is a problem to use 0 when host is NULL, then the code could be fixed
>> in another way.
>>
>
> Yeah. It seems like it would be better to give a clearly bogus number.
> I would have said -1 but "scsi-1" looks normal so maybe something like
> 9999999?
>

lets spend some bytes:


if (host)
dprintk("scsi%d: hptiop_probe failed\n",host->host_no);
else
dprintk("scsi: no host, hptiop_probe failed\n");



re,
wh



\
 
 \ /
  Last update: 2010-05-27 19:11    [W:0.061 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site