lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] perf: fix use_browser infinite loop bug in annotate
    Em Thu, May 27, 2010 at 02:50:01PM +0200, Stephane Eranian escreveu:
    > This patch fixes an infinite loop problem with perf annotate when
    > the TUI is not used. When the perfconfig file is not found use_browser
    > remains at -1, when found and tui is disabled use_browser = 0. Thus the
    > correct test for TUI is use_browser > 0.
    >
    > Signed-off-by: Stephane Eranian <eranian@google.com>

    Thanks, I'm applying this one and doing an audit of other uses, I know
    of one more case reported by Frédéric that was fixed in a similar way.

    > diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
    > index 08278ed..96db524 100644
    > --- a/tools/perf/builtin-annotate.c
    > +++ b/tools/perf/builtin-annotate.c
    > @@ -343,7 +343,7 @@ find_next:
    > continue;
    > }
    >
    > - if (use_browser) {
    > + if (use_browser > 0) {
    > key = hist_entry__tui_annotate(he);
    > if (is_exit_key(key))
    > break;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-27 16:55    [W:0.020 / U:29.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site