Messages in this thread | | | Date | Thu, 27 May 2010 16:12:54 +0300 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH 2/3] workqueue: Add an API to create a singlethread workqueue attached to the current task's cgroup |
| |
On Thu, May 27, 2010 at 02:44:48PM +0200, Oleg Nesterov wrote: > On 05/27, Michael S. Tsirkin wrote: > > > > On Tue, May 18, 2010 at 05:04:51PM -0700, Sridhar Samudrala wrote: > > > Add a new kernel API to create a singlethread workqueue and attach it's > > > task to current task's cgroup and cpumask. > > > > > > Signed-off-by: Sridhar Samudrala <sri@us.ibm.com> > > > > Could someone familiar with workqueue code please comment on whether > > this patch is suitable for 2.6.35? > > > > It is needed to fix the case where vhost user might cause a kernel > > thread to consume more CPU than allowed by the cgroup. > > Should I merge it through the vhost tree? > > Ack for this? > > I don't understand the reasons for this patch, but this doesn't matter.
Depending on userspace application, driver can create a lot of work for a workqueue to handle. By making the workqueue thread belong in a cgroup, we make it possible to the CPU and other resources thus consumed.
-- MST
| |