lkml.org 
[lkml]   [2010]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock
    On Thu, 27 May 2010, Roedel, Joerg wrote:

    > On Wed, May 26, 2010 at 11:55:59AM -0400, Julia Lawall wrote:
    > > The semantic match that finds this problem is as follows:
    > > (http://coccinelle.lip6.fr/)
    > >
    > > // <smpl>
    > > @@
    > > expression E1;
    > > @@
    > >
    > > * spin_lock(E1,...);
    > > <+... when != E1
    > > if (...) {
    > > ... when != E1
    > > * return ...;
    > > }
    > > ...+>
    > > * spin_unlock(E1,...);
    > > // </smpl>
    >
    > Btw, I think it would be great to have a collection of these semantic
    > match scripts in the kernel repository together with a build target to
    > run these scripts over the kernel sources (like the cscope target).
    > Opinions?

    We have submitted and received some feedback on an initial version of
    this, but I'm not completely sure of the current status.

    julia


    \
     
     \ /
      Last update: 2010-05-27 13:21    [W:0.031 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site