Messages in this thread |  | | | Date | Thu, 27 May 2010 13:17:58 +0200 (CEST) | | From | Julia Lawall <> | | Subject | Re: [PATCH 6/17] arch/x86/kernel: Add missing spin_unlock |
| |
On Thu, 27 May 2010, Roedel, Joerg wrote:
> On Wed, May 26, 2010 at 11:55:59AM -0400, Julia Lawall wrote: > > The semantic match that finds this problem is as follows: > > (http://coccinelle.lip6.fr/) > > > > // <smpl> > > @@ > > expression E1; > > @@ > > > > * spin_lock(E1,...); > > <+... when != E1 > > if (...) { > > ... when != E1 > > * return ...; > > } > > ...+> > > * spin_unlock(E1,...); > > // </smpl> > > Btw, I think it would be great to have a collection of these semantic > match scripts in the kernel repository together with a build target to > run these scripts over the kernel sources (like the cscope target). > Opinions?
We have submitted and received some feedback on an initial version of this, but I'm not completely sure of the current status.
julia
|  |