Messages in this thread | | | Date | Wed, 26 May 2010 11:19:58 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 1/7] hugetlb, rmap: add reverse mapping for hugepage |
| |
Mel, other than this nit are you happy with these changes now?
> > It adds another header dependency which is bad but moving hugetlb stuff > > into mm.h seems bad too. > > I have another choice to move the definition of is_vm_hugetlb_page() into > mm/hugetlb.c and introduce declaration of this function to pagemap.h, > but this needed a bit ugly #ifdefs and I didn't like it. > If putting hugetlb code in mm.h is worse, I'll take the second choice > in the next post.
You could always create a new include file hugetlb-inlines.h
-Andi -- ak@linux.intel.com -- Speaking for myself only.
| |