lkml.org 
[lkml]   [2010]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] tmpfs: Quick token library to allow scalable retrieval of tokens from token jar
From
Date
Andrew,

I've fixed the issues that you brought up for this patch series. I have
sent out version 2 patches in separate mails.
I've followed up on one of your comments below to explain why I'm doing
things done differently from your suggestions.

On Thu, 2010-05-20 at 16:08 -0700, Andrew Morton wrote:

> > +
> > +struct qtoken {
> > + long pool; /* pool of free tokens */
> > + long total; /* total num of tokens */
> > +#ifdef CONFIG_SMP
> > + long init_cache_sz; /* initial cache size */
>
> I don't think that it si meaningful for any of these things to have
> negative values, so an unsigned type would be more appropriate.
>
> Did they really need to be `long'? Plain old `unsigned' might be more
> efficient, perhaps.

I've changed "pool" and "total" to unsigned long. However, since tmpfs
uses unsigned long for the free blocks, I have to use unsigned long
instead of unsigned for the token jar to maintain compatibility with
tmpfs.


Thank you for your review.

Regards,
Tim Chen



\
 
 \ /
  Last update: 2010-05-26 21:39    [W:0.096 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site