lkml.org 
[lkml]   [2010]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] asm-generic: Use raw_local_irq_save/restore instead local_irq_save/restore
From
Date
On Wed, 2010-05-26 at 10:08 -0700, Andrew Morton wrote:

>
> If a developer looks at atomic_add_return() and asks himself "why did
> this use raw_local_irq_save()", the only way of answering that question
> is to go groveling through the git logs, which is a right PITA if
> you're trying to get some coding work done.
>
> Guys, any time you add code which is non-obvious at the raw C level, it
> *needs* a comment!

Totally agree! I've gotten pretty good at adding comments to changes
like this that I do. I need to get better at telling others to comment
their work ;-)

-- Steve





\
 
 \ /
  Last update: 2010-05-26 19:15    [W:0.065 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site