lkml.org 
[lkml]   [2010]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/10] vmscan: Remove unnecessary temporary variables in shrink_zone()
    On Sat, Apr 17, 2010 at 01:03:32AM +0200, Johannes Weiner wrote:
    > On Fri, Apr 16, 2010 at 11:51:26AM +0900, KOSAKI Motohiro wrote:
    > > > Two variables are declared that are unnecessary in shrink_zone() as they
    > > > already exist int the scan_control. Remove them
    > > >
    > > > Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    > >
    > > ok.
    > > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    >
    > You confuse me, you added the local variables yourself in 01dbe5c9
    > for performance reasons. Doesn't that still hold?
    >

    To avoid a potential regression, I've dropped the patch.

    --
    Mel Gorman
    Part-time Phd Student Linux Technology Center
    University of Limerick IBM Dublin Software Lab


    \
     
     \ /
      Last update: 2010-05-26 13:25    [W:0.025 / U:1.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site