Messages in this thread | | | From | "Altobelli, David" <> | Date | Tue, 25 May 2010 22:16:10 +0000 | Subject | RE: [PATCH]: hpilo: fix pointer warning in ilo_ccb_setup |
| |
> Seems very wrong - writes to *dmp_pa will now scribble over > the `struct ccb_data'.
Yeah. The dma_pa variable is used to track the physical address of the DMA memory, and it is written to the device. We don't want a kernel pointer, we want the actual physical addr, plus the various offsets.
> Probably local variable dma_pa should have type dma_addr_t.
I feel like I tried that, and I had trouble setting or using the send_fifobar/recv_fifobar variables. But I probably didn't try too hard.
| |