lkml.org 
[lkml]   [2010]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH]: hpilo: fix pointer warning in ilo_ccb_setup
> Seems very wrong - writes to *dmp_pa will now scribble over 
> the `struct ccb_data'.

Yeah. The dma_pa variable is used to track the physical
address of the DMA memory, and it is written to the device.
We don't want a kernel pointer, we want the actual physical addr,
plus the various offsets.

> Probably local variable dma_pa should have type dma_addr_t.

I feel like I tried that, and I had trouble setting or using
the send_fifobar/recv_fifobar variables. But I probably
didn't try too hard.


\
 
 \ /
  Last update: 2010-05-26 00:21    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site