lkml.org 
[lkml]   [2010]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] padata: add parenthesis in MAX_SEQ_NR macro
    MAX_SEQ_NR is used in padata_alloc_pd() like this:

    pd->max_seq_nr = (MAX_SEQ_NR / num_cpus) * num_cpus - 1;

    It needs parenthesis or the divide by num_cpus takes precedence over the
    subtraction.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    ---
    Found by a static checker. I don't really know this code.

    diff --git a/kernel/padata.c b/kernel/padata.c
    index b1c9857..ff8de1b 100644
    --- a/kernel/padata.c
    +++ b/kernel/padata.c
    @@ -28,7 +28,7 @@
    #include <linux/slab.h>
    #include <linux/rcupdate.h>

    -#define MAX_SEQ_NR INT_MAX - NR_CPUS
    +#define MAX_SEQ_NR (INT_MAX - NR_CPUS)
    #define MAX_OBJ_NUM 1000

    static int padata_index_to_cpu(struct parallel_data *pd, int cpu_index)

    \
     
     \ /
      Last update: 2010-05-25 23:33    [W:0.018 / U:181.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site