Messages in this thread | | | Date | Tue, 25 May 2010 19:53:34 +0300 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH 1/3] cgroups: Add an API to attach a task to current task's cgroup |
| |
On Thu, May 20, 2010 at 03:22:15PM -0700, Paul Menage wrote: > On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala > <samudrala.sridhar@gmail.com> wrote: > > Add a new kernel API to attach a task to current task's cgroup > > in all the active hierarchies. > > > > Signed-off-by: Sridhar Samudrala <sri@us.ibm.com> > > Reviewed-by: Paul Menage <menage@google.com> > > It would be more efficient to just attach directly to current->cgroups > rather than potentially creating/destroying one css_set for each > hierarchy until we've completely converged on current->cgroups - but > that would require a bunch of refactoring of the guts of > cgroup_attach_task() to ensure that the right can_attach()/attach() > callbacks are made. That doesn't really seem worthwhile right now for > the initial use, that I imagine isn't going to be > performance-sensitive. > > Paul
Is this patch suitable for 2.6.35? It is needed to fix the case where vhost user might cause a kernel thread to consume more CPU than allowed by the cgroup. Should I just merge it through the vhost tree? Ack for this?
Thanks,
-- MST
| |