Messages in this thread | | | Date | Tue, 25 May 2010 13:35:19 +0800 | From | Cong Wang <> | Subject | Re: proc_dointvec() and write |
| |
On 05/25/10 12:57, J. R. Okajima wrote: > Cong Wang: >> Hmm, odd, I tested other proc files, I see no problem. >> I am wondering why /proc/sys/kernel/printk is special here. > > The condition is, > - the entry has multiple values, .maxlen = N * sizeof(foo) > - the entry is writable, .mode = 0644 (or something) > > In sysctl.c, only "printk" and "acct" match.
Hmm, right, I missed this case during testing.
Your patch looks correct for me. Would you mind to send your patch again with your Signed-off-by?
Thank you!
| |