Messages in this thread |  | | | From | Mike Frysinger <> | | Date | Mon, 24 May 2010 21:29:34 -0400 | | Subject | Re: [Uclinux-dist-devel] [PATCH -mm 1/1] ptrace: PTRACE_GETFDPIC: fix the unsafe usage of child->mm |
| |
On Mon, May 24, 2010 at 19:42, Roland McGrath wrote: >> You mean, pass it to arch_ptrace() ? >> >> grep, grep, grep. I guess I understand you. We have more unsafe code >> like this in arch/*/kernel/ptrace.c. Of course, it can be fixed without >> doing get_task_mm() in sys_ptrace(), but perhaps it would be more clean >> to do what you suggest. >> >> Roland, what do you think? > > The mm pointer is only used by these uncommon ptrace operations that exist > only in certain unusual arch's (and they're all ill-advised old arch ptrace > ABI additions, at that).
are you suggesting the FDPIC additions are ill-advised as well ? curious how you would have implemented this if that's the case ... -mike
|  |