Messages in this thread | | | Date | Mon, 24 May 2010 16:07:29 +0100 | From | Alasdair G Kergon <> | Subject | Re: [dm-devel] [PATCH v3 3/3] dm: lookup devices by path with name_to_dev_t |
| |
On Mon, May 24, 2010 at 09:44:07AM -0500, Will Drewry wrote: > fwiw, the only reason for the copy was because |path| is a > const in the function but not when passed to name_to_dev_t. > I wasn't sure what the preferred practice was so I just duped > the data needed.
Well check that it is treated as 'const' and send a separate patch to the maintainer to add const, perhaps? If it isn't const (why would that be?), then yes we'd need to copy it.
Alasdair
| |