Messages in this thread | | | From | "Aneesh Kumar K. V" <> | Subject | Re: [PATCH -V11 1/9] exportfs: Return the minimum required handle size | Date | Sat, 22 May 2010 14:02:23 +0530 |
| |
On Fri, 21 May 2010 18:15:16 -0400, "J. Bruce Fields" <bfields@fieldses.org> wrote: > On Thu, May 20, 2010 at 01:05:30PM +0530, Aneesh Kumar K.V wrote: > > The exportfs encode handle function should return the minimum required > > handle size. This helps user to find out the handle size by passing 0 > > handle size in the first step and then redoing to the call again with > > the returned handle size value. > > The encode_fh() interface is a little confusing. (Not your fault, > really, mainly it's the return value (and the special use of 255) that I > always find odd.) > > But maybe it would help to have a little more documention in the > export_encode_fh() kerneldoc comment and/or in > Documentation/filesystems/nfs/Exporting? >
Will update in the next iteration.
-aneesh
| |