lkml.org 
[lkml]   [2010]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/3] perf tui: Remove annotate from popup menu after failure
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    Cc: Frédéric Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Tom Zanussi <tzanussi@gmail.com>
    LKML-Reference: <new-submission>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/newt.c | 5 +++++
    1 files changed, 5 insertions(+), 0 deletions(-)

    diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c
    index 0b45658..c65838c 100644
    --- a/tools/perf/util/newt.c
    +++ b/tools/perf/util/newt.c
    @@ -914,6 +914,9 @@ int hists__browse(struct hists *self, const char *helpline, const char *input_na

    switch (toupper(es.u.key)) {
    case 'A':
    + if (browser->selection->map == NULL &&
    + browser->selection->map->dso->annotate_warned)
    + continue;
    goto do_annotate;
    case 'D':
    goto zoom_dso;
    @@ -957,6 +960,7 @@ do_help:
    }

    if (browser->selection->sym != NULL &&
    + !browser->selection->map->dso->annotate_warned &&
    asprintf(&options[nr_options], "Annotate %s",
    browser->selection->sym->name) > 0)
    annotate = nr_options++;
    @@ -991,6 +995,7 @@ do_help:
    struct hist_entry *he;
    do_annotate:
    if (browser->selection->map->dso->origin == DSO__ORIG_KERNEL) {
    + browser->selection->map->dso->annotate_warned = 1;
    ui_helpline__puts("No vmlinux file found, can't "
    "annotate with just a "
    "kallsyms file");
    --
    1.6.2.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-22 19:49    [W:0.021 / U:30.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site