Messages in this thread |  | | | From | KOSAKI Motohiro <> | | Subject | Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at first | | Date | Sat, 22 May 2010 09:04:30 +0900 (JST) |
| |
> > -static inline void lru_cache_add_active_anon(struct page *page) > > -{ > > - __lru_cache_add(page, LRU_ACTIVE_ANON); > > -} > > - > > static inline void lru_cache_add_file(struct page *page) > > { > > __lru_cache_add(page, LRU_INACTIVE_FILE); > > } > > > > -static inline void lru_cache_add_active_file(struct page *page) > > -{ > > - __lru_cache_add(page, LRU_ACTIVE_FILE); > > -} > > Did you intend to remove these two functions?
This is for applying Hannes's commnet.
> They do appear to be unused now, but they still make sense and might be > used in the future, perhaps.
Personally, I don't like the strategy that anyone without me might use this function in the future. because It often never come.
> It's OK to remove them, but I'm wondering > if it was deliberately included in this patch?
Makes sense. OK, please drop current patch at once. I'll post V2.
|  |