lkml.org 
[lkml]   [2010]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 23/25] serial: bfin_sport_uart: Use resource size to fix off-by-one error
    Date
    From: Tobias Klauser <tklauser@distanz.ch>

    Use the resource_size function instead of manually calculating the
    resource size. This actually fixes an off-by-one error.

    Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/serial/bfin_sport_uart.c | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/drivers/serial/bfin_sport_uart.c b/drivers/serial/bfin_sport_uart.c
    index 66cda22..e57fb3d 100644
    --- a/drivers/serial/bfin_sport_uart.c
    +++ b/drivers/serial/bfin_sport_uart.c
    @@ -774,8 +774,7 @@ static int __devinit sport_uart_probe(struct platform_device *pdev)
    goto out_error_free_peripherals;
    }

    - sport->port.membase = ioremap(res->start,
    - res->end - res->start);
    + sport->port.membase = ioremap(res->start, resource_size(res));
    if (!sport->port.membase) {
    dev_err(&pdev->dev, "Cannot map sport IO\n");
    ret = -ENXIO;
    --
    1.7.0.3


    \
     
     \ /
      Last update: 2010-05-21 18:55    [W:4.994 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site