lkml.org 
[lkml]   [2010]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arch/tile: new multi-core architecture for Linux
    On 5/20/2010 9:52 PM, Barry Song wrote:
    > On 5/20/2010 1:04 AM, Barry Song wrote:
    >>> Your patch is not compilable, and the subject doesn't match well with
    >>> the content. I think you need re-organize patches.
    >>>
    > Where does the blade_pci symbol come from? "No matches found" by a
    > grep. Is it exported in your local codes?
    > Why not just use #if CONFIG_TILE to cover your quirk_tile_blade. And
    > where is CONFIG_TILE?
    >

    Oh, I see; I thought you were referring to the other bit of quoted
    patch. Yes, this should be guarded by #ifdef TILE_CONFIG - thanks!

    > I guess all will be explained by your arch codes, but this patch
    > depends on your arch codes, so it shouldn't be here by itself.
    >

    The arch code is all at

    http://www.tilera.com/scm/linux-2.6.34-arch-tile.tar.bz2

    I have been reluctant to send it to LKML as an email patch, since it's
    270 files, 87 KLoC, about 2.5 MB. I could break it down into multiple
    patches (arch/tile/kernel/, arch/tile/mm, arch/tile/lib, etc.).

    I solicit opinions from the community as to what is the best approach :-)

    Meanwhile I'll resend the original platform-independent changes (the
    MAINTAINER stanza, one line in the PIC Makefile, and the quirk change)
    as updated git-am patches.

    --
    Chris Metcalf, Tilera Corp.
    http://www.tilera.com




    \
     
     \ /
      Last update: 2010-05-21 17:17    [W:6.296 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site