Messages in this thread | | | Date | Thu, 20 May 2010 22:54:54 -0700 (PDT) | Subject | Re: [PATCH 2/2]: atomic_t: Remove volatile from atomic_t definition | From | David Miller <> |
| |
From: Nick Piggin <npiggin@suse.de> Date: Fri, 21 May 2010 15:27:46 +1000
> Hmm, I'm missing something. David, back up a second, as far as I can see, > with Anton's patches, atomic_read() *is* effectively just ACCESS_ONCE() > now. Linus pointed out that header tangle is the reason not to just use > the macro.
My bad, I was under the impression that the proposal was to remove volatile usage and also not even do ACCESS_ONCE() in atomic_read().
And then explicitly annotate call sits that actually need the ACCESS_ONCE() semantic.
| |