Messages in this thread | | | Date | Mon, 3 May 2010 11:38:04 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 6/8] padata: Use a timer to handle the reorder queues |
| |
On Fri, Apr 30, 2010 at 01:20:00PM +0200, Steffen Klassert wrote: > On Thu, Apr 29, 2010 at 04:06:44PM -0700, Andrew Morton wrote: > > On Thu, 29 Apr 2010 14:43:37 +0200 > > Steffen Klassert <steffen.klassert@secunet.com> wrote: > > > > > padata_get_next had a bogus check that returned always true, > > > so the try_again loop in padata_reorder was never taken. > > > > A better changelog would have told us what this "bogus check" _is_. > > > > > This can lead to object leaks in some rare cases. > > > > And a better changelog would describe those leaks! > > I'll try to write a better one and resent.
I've picked up patches 1-5.
Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |