Messages in this thread |  | | | Date | Thu, 20 May 2010 13:03:24 +1000 | | From | Paul Mackerras <> | | Subject | Re: [PATCH] powerpc: Fix string library functions |
| |
On Tue, May 18, 2010 at 08:15:21PM +0200, Andreas Schwab wrote:
> The powerpc strncmp implementation does not correctly handle a zero > length, despite the claim in 0119536cd314ef95553604208c25bc35581f7f0a > (Add hand-coded assembly strcmp). > > Additionally, all the length arguments are size_t, not int, so use > PPC_LCMPI and eq instead of cmpwi and le throughout. > > Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
Looks fine to me.
Acked-by: Paul Mackerras <paulus@samba.org>
|  |