[lkml]   [2010]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] powerpc: Fix string library functions
    On Tue, May 18, 2010 at 08:15:21PM +0200, Andreas Schwab wrote:

    > The powerpc strncmp implementation does not correctly handle a zero
    > length, despite the claim in 0119536cd314ef95553604208c25bc35581f7f0a
    > (Add hand-coded assembly strcmp).
    > Additionally, all the length arguments are size_t, not int, so use
    > PPC_LCMPI and eq instead of cmpwi and le throughout.
    > Signed-off-by: Andreas Schwab <>

    Looks fine to me.

    Acked-by: Paul Mackerras <>

     \ /
      Last update: 2010-05-20 05:07    [W:0.021 / U:2.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site