Messages in this thread | | | Date | Wed, 19 May 2010 11:02:04 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/8] autofs: Pushdown the bkl from ioctl |
| |
On 05/19/2010 10:24 AM, Frederic Weisbecker wrote: > * generate kernel reactions > */ > -static int autofs_root_ioctl(struct inode *inode, struct file *filp, > +static int autofs_root_ioctl_unlocked(struct inode *inode, struct file *filp, > unsigned int cmd, unsigned long arg) > { > struct autofs_sb_info *sbi = autofs_sbi(inode->i_sb); > @@ -579,3 +579,16 @@ static int autofs_root_ioctl(struct inode *inode, struct file *filp, > return -ENOSYS; > } > } > + > +static long autofs_root_ioctl(struct file *filp, > + unsigned int cmd, unsigned long arg) > +{
The choice of naming here seems reverse in my opinion.
-hpa
| |