lkml.org 
[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BUG] SLOB breaks Crypto
    On Wed, May 19, 2010 at 12:20:34AM +0100, David Woodhouse wrote:
    >
    > It would be better if the minimum alignment was exposed to generic code
    > though -- you're right that the CPP tests in linux/crypto.h really
    > shouldn't have to exist. If it wasn't for that, then the crypto problem
    > wouldn't have occurred.

    While this problem wouldn't have occurred, we would instead have
    data corruption/alignment faults on architectures such as sparc32
    or ARM that require 64-bit alignment for 64-bit objects.

    So no getting rid of them isn't going to fix things either. Of
    course I have no objections to moving this into slab.h or a similar
    location should anyone be willing to do the hard work.

    Thanks,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2010-05-19 03:09    [W:0.039 / U:119.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site