Messages in this thread | | | Date | Wed, 19 May 2010 01:00:48 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 2/2] v4 x86/mrst: add more timer config options |
| |
On Tue, 18 May 2010, jacob pan wrote:
> > >> > >> +/** > > > > Do not use kerneldoc /** opener from plain comments. Randy > > complained about that yesterday already > > > I missed randy's comment at the end. sorry. I admit I did not know kernel-doc > before that. > > if (mrst_identify_cpu() == MRST_CPU_CHIP_PENWELL) { > > > > Why do you want to pin that on PENWELL and not on ARAT ? If you > > check ARAT, you have coverd all next gen cpus as well. > > I did try ARAT first but ARAT is not available at this point. the add-on cpu > features are set later.
Hmm, I don't see a reason why we don't to the readout of the extra features right away. I might be missing something really important though :) hpa ?????
Thanks,
tglx
| |