lkml.org 
[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -tip v2 1/5] [BUGFIX] kprobes: Fix selftest to clear flags field for reusing probes
    Date
    Fix selftest to clear flags field for reusing probes
    because the flags field can be modified by Kprobes.

    Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
    Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Jim Keniston <jkenisto@us.ibm.com>
    Cc: Jason Baron <jbaron@redhat.com>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    ---

    kernel/test_kprobes.c | 12 +++++++++---
    1 files changed, 9 insertions(+), 3 deletions(-)

    diff --git a/kernel/test_kprobes.c b/kernel/test_kprobes.c
    index 4f10451..ede20f4 100644
    --- a/kernel/test_kprobes.c
    +++ b/kernel/test_kprobes.c
    @@ -115,7 +115,9 @@ static int test_kprobes(void)
    int ret;
    struct kprobe *kps[2] = {&kp, &kp2};

    - kp.addr = 0; /* addr should be cleard for reusing kprobe. */
    + /* addr and flags should be cleard for reusing kprobe. */
    + kp.addr = 0;
    + kp.flags = 0;
    ret = register_kprobes(kps, 2);
    if (ret < 0) {
    printk(KERN_ERR "Kprobe smoke test failed: "
    @@ -210,7 +212,9 @@ static int test_jprobes(void)
    int ret;
    struct jprobe *jps[2] = {&jp, &jp2};

    - jp.kp.addr = 0; /* addr should be cleard for reusing kprobe. */
    + /* addr and flags should be cleard for reusing kprobe. */
    + jp.kp.addr = 0;
    + jp.kp.flags = 0;
    ret = register_jprobes(jps, 2);
    if (ret < 0) {
    printk(KERN_ERR "Kprobe smoke test failed: "
    @@ -323,7 +327,9 @@ static int test_kretprobes(void)
    int ret;
    struct kretprobe *rps[2] = {&rp, &rp2};

    - rp.kp.addr = 0; /* addr should be cleard for reusing kprobe. */
    + /* addr and flags should be cleard for reusing kprobe. */
    + rp.kp.addr = 0;
    + rp.kp.flags = 0;
    ret = register_kretprobes(rps, 2);
    if (ret < 0) {
    printk(KERN_ERR "Kprobe smoke test failed: "

    --
    Masami Hiramatsu
    e-mail: mhiramat@redhat.com


    \
     
     \ /
      Last update: 2010-05-18 22:11    [W:0.027 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site