lkml.org 
[lkml]   [2010]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] fix a code style in drivers/char/virtio_console.c
    From
    Hi, Amit,

    if 'err' initialised in this path, it needn't do err = -ENOMEM
    after,isn't it?



    Best regards


    2010/5/18 Amit Shah <amit.shah@redhat.com>:
    > On (Tue) May 18 2010 [13:17:22], Steven Liu wrote:
    >> fix a code style in drivers/char/virtio_console.c
    >>
    >> Signed-off-by: Liu Qi <lingjiujianke@gmail.com>
    >
    > NACK.
    >
    > This style is deliberate and follows Rusty's style: if we end up using
    > 'err' uninitialised in some code path, it can get flagged by source
    > checkers.
    >
    >                Amit
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-18 07:43    [W:0.021 / U:0.968 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site