lkml.org 
[lkml]   [2010]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 0/8] Suspend block api (version 7)
    From
    2010/5/16 Rafael J. Wysocki <rjw@sisk.pl>:
    > On Friday 14 May 2010, Arve Hjønnevåg wrote:
    >> This patch series adds a suspend-block api that provides the same
    >> functionality as the android wakelock api. This version has some
    >> changes from, or requested by, Rafael. The most notable changes are:
    >> - DEFINE_SUSPEND_BLOCKER and suspend_blocker_register have been added
    >>   for statically allocated suspend blockers.
    >> - suspend_blocker_destroy is now called suspend_blocker_unregister
    >> - The user space mandatory _INIT ioctl has been replaced with an
    >>   optional _SET_NAME ioctl.
    >>
    >> I kept the ack and reviewed by tags on two of the patches even though
    >> there were a few cosmetic changes.
    >
    > I have one more comment, sorry for that.
    >
    > Namely, if /sys/power/policy is set to "opportunistic" and "mem" is written
    > into /sys/power/state and there are no suspend blockers present except for
    > the main blocker (and the blockers used only for statistics), the system won't
    > be able to go out of an infinit suspend-resume loop (or at least it seems
    > so from reading the code).
    >
    > I think we should prevent that from happening somehow.
    >

    It should get out of that loop as soon as someone blocks suspend. If
    someone is constantly aborting suspend without using a suspend blocker
    it will be very inefficient, but it should still work.

    --
    Arve Hjønnevåg
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-17 06:19    [W:0.034 / U:0.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site