[lkml]   [2010]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/1] tracing/sched: Fix task states in sched_switch event
Hi Ingo,

> The whole enumeration there is pointless in that .c file - it tells nothing
> to the code reader.

> If it cannot be expressed in a meaningful way then introduce
> TASK_STATE_STRINGS_INIT construct that is defined next to the strings (in a
> .h file or so) - that way it's a coherent whole.
The updated patch
- has all definitions at a common place,
- adapts the related comment,
- makes the string array declaration in fs/proc/array.c a one-liner.


 \ /
  Last update: 2010-05-17 00:27    [W:0.038 / U:0.300 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site