lkml.org 
[lkml]   [2010]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.34-rc7] HID: hid-samsung: add support for Creative Desktop Wireless 6000
    On 16/05/10 11:33, Robert Schedel wrote:

    > Hello,
    >
    > On 16.05.2010 02:32, Don Prince wrote:
    >
    >> Add support for the Creative Desktop Wireless 6000 keyboard/mouse
    >> bundle's multimedia buttons which are not currently handled by
    >> the default/samsung HID driver.
    >>
    >> Signed-off-by: Don Prince <dhprince-devel@yahoo.co.uk>
    >>
    >> ---
    >> [...]
    >>
    > As originator of the "old" 0419:0001 IrDA driver parts had a short look at it:
    > - Merging with old code looks OK. Tested with old 0419:0001 (184) device, still functional.
    > - 0419:0600 not yet known in usb.ids, might be worth a contribution
    > - As you merged in a new device, and for explaining why this handling was added, my suggestion is to adapt the existing comments, e.g.:
    >
    > /*
    > * This driver supports several HID devices:
    > *
    > * [0419:0001] Samsung IrDA remote controller (reports as Cypress USB Mouse).
    > *
    > * There are several variants:
    > *
    > * 1. 184 byte report descriptor
    > [...]
    > * [0419:0600] Creative Desktop Wireless 6000 keyboard/mouse combo
    > *
    > * Several key mappings used from the consumer usage page
    > * deviate from the USB HUT 1.12 standard.
    > */
    >
    > Of course some HID maintainer should also review it, for general policy.
    >
    > Regards,
    > Robert Schedel
    >
    >
    Ok I'll add some comments and re-submit patch as v2.

    Regards

    Don Prince



    \
     
     \ /
      Last update: 2010-05-16 14:19    [W:0.022 / U:64.988 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site