Messages in this thread | | | Date | Sun, 16 May 2010 14:46:03 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] lktdm: Bring support for hardlockup, softlockup and hung task crashes |
| |
On Sun, May 16, 2010 at 12:35:08PM +0200, Frederic Weisbecker wrote: ... > > Looks good to me. Btw perhaps we may simplify it a bit: > > > > case HARDLOCKUP: > > local_irq_disable(); > > case SOFTLOCKUP: > > preempt_disable(); > > for (;;) > > cpu_relax(); > > break; > > > > since it'll save a few bytes. What do you think? Did I miss > > something? > > > It would make the code a bit less clear in that people > might stick on the reason to disable preemption after disabling > irq, especially with a code that already does something rather > unusual ;) >
ok, convinced
-- Cyrill
| |