lkml.org 
[lkml]   [2010]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lktdm: Bring support for hardlockup, softlockup and hung task crashes
On Sun, May 16, 2010 at 12:35:08PM +0200, Frederic Weisbecker wrote:
...
> > Looks good to me. Btw perhaps we may simplify it a bit:
> >
> > case HARDLOCKUP:
> > local_irq_disable();
> > case SOFTLOCKUP:
> > preempt_disable();
> > for (;;)
> > cpu_relax();
> > break;
> >
> > since it'll save a few bytes. What do you think? Did I miss
> > something?
>
>
> It would make the code a bit less clear in that people
> might stick on the reason to disable preemption after disabling
> irq, especially with a code that already does something rather
> unusual ;)
>

ok, convinced

-- Cyrill


\
 
 \ /
  Last update: 2010-05-16 12:49    [W:0.034 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site