[lkml]   [2010]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 1/2] perf tui: Make <- exit menus too
    From: Arnaldo Carvalho de Melo <>

    In fact it is now added to the hot key list when newt_form__new is used,
    allowing us to remove the explicit assignment in all its users.

    The visible change is that <- will exit the menu that pops up when -> is
    pressed (and Enter when callchains are not being used).

    Suggested-by: Ingo Molnar <>
    Cc: Frédéric Weisbecker <>
    Cc: Mike Galbraith <>
    Cc: Paul Mackerras <>
    Cc: Peter Zijlstra <>
    Cc: Tom Zanussi <>
    LKML-Reference: <new-submission>
    Signed-off-by: Arnaldo Carvalho de Melo <>
    tools/perf/util/newt.c | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/util/newt.c b/tools/perf/util/newt.c
    index 6974431..59a63e4 100644
    --- a/tools/perf/util/newt.c
    +++ b/tools/perf/util/newt.c
    @@ -118,6 +118,7 @@ int browser__show_help(const char *format, va_list ap)

    static void newt_form__set_exit_keys(newtComponent self)
    + newtFormAddHotKey(self, NEWT_KEY_LEFT);
    newtFormAddHotKey(self, NEWT_KEY_ESCAPE);
    newtFormAddHotKey(self, 'Q');
    newtFormAddHotKey(self, 'q');
    @@ -323,7 +324,6 @@ static int ui_browser__run(struct ui_browser *self, const char *title,
    newtFormAddHotKey(self->form, NEWT_KEY_PGDN);
    newtFormAddHotKey(self->form, NEWT_KEY_HOME);
    newtFormAddHotKey(self->form, NEWT_KEY_END);
    - newtFormAddHotKey(self->form, NEWT_KEY_LEFT);

    if (ui_browser__refresh_entries(self) < 0)
    return -1;
    @@ -757,7 +757,6 @@ static int hist_browser__populate(struct hist_browser *self, struct hists *hists
    newtFormAddHotKey(self->form, 'T');
    newtFormAddHotKey(self->form, 't');
    newtFormAddHotKey(self->form, NEWT_KEY_RIGHT);
    - newtFormAddHotKey(self->form, NEWT_KEY_LEFT);
    newtFormAddComponents(self->form, self->tree, NULL);
    self->selection = newt__symbol_tree_get_current(self->tree);

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2010-05-17 02:13    [W:0.026 / U:5.904 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site