Messages in this thread | | | Date | Mon, 17 May 2010 00:51:30 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 3/8] x86/mrst: add more timer options to include Medfield |
| |
On Fri, 14 May 2010, Jacob Pan wrote: > > -/* > - * the secondary clock in Moorestown can be APBT or LAPIC clock, default to > - * APBT but cmdline option can also override it. > - */ > static void __cpuinit mrst_setup_secondary_clock(void) > { > - /* restore default lapic clock if disabled by cmdline */ > - if (disable_apbt_percpu) > - return setup_secondary_APIC_clock(); > + if ((mrst_timer_options == MRST_TIMER_APBT_ONLY)) > + return apbt_setup_secondary_clock();
Did you compile this ?
> + if (cpu_has(¤t_cpu_data, X86_FEATURE_ARAT) > + || (mrst_timer_options == MRST_TIMER_LAPIC_APBT)) { > + pr_info("using lapic timers for secondary clock\n"); > + setup_secondary_APIC_clock(); > + return; > + }
As I said before, this function sucks. The decision logic is just obscure. It's not rocket science to make it understandable.
> apbt_setup_secondary_clock(); > }
Thanks,
tglx
| |