Messages in this thread |  | | | Date | Fri, 14 May 2010 16:08:04 -0700 | | From | Yinghai <> | | Subject | Re: [PATCH 07/37] lmb: Add lmb_find_area() |
| |
On 05/14/2010 03:39 PM, Benjamin Herrenschmidt wrote: > On Fri, 2010-05-14 at 12:45 -0700, Yinghai Lu wrote: >> it is a wrapper for lmb_find_base >> >> make it more easy for x86 to use lmb. ( rebase ) >> x86 early_res is using find/reserve pattern instead of alloc. >> >> keep it in weak version, so later We can use x86 own version if needed. >> also We need it in lib/lmb.c, so one called mm/page_alloc.c could get compiled > > I seem to have told you that I didn't want to have that thing in the > core :-) > > You keep adding those "wrappers" which basically just do prototype > adaptation and in this case a bit of cropping, with a name that is > utterly confusing as to what their intent is. > > I might have accepted that one if you had called it something like > lmb_find_in_range() which at least -means- something.
thanks. will use sed to replace them.
lmb_find_area ==> lmb_find_in_range()
how about lmb_reserve_area ==> lmb_reserve_range lmb_free_area ==> lmb_free_range or leave them that way, later replace them lmb_reserve and lmb_free one by one?
YH
|  |