lkml.org 
[lkml]   [2010]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC, 3/7] NUMA hotplug emulator
Wu Fengguang wrote:
>> Pls. replace it with following code:
>>
>> +#ifdef CONFIG_NODE_HOTPLUG_EMU
>> +static ssize_t store_nodes_probe(struct sysdev_class *class,
>> + struct sysdev_class_attribute *attr,
>> + const char *buf, size_t count)
>> +{
>> + long nid;
>> + int ret;
>> +
>> + ret = strict_strtol(buf, 0, &nid);
>> + if (ret == -EINVAL)
>> + return ret;
>> +
>> + ret = hotadd_hidden_nodes(nid);
>> + if (!ret)
>> + return count;
>> + else
>> + return -EIO;
>> +}
>> +#endif
>
> How about this?
>
> err = strict_strtol(buf, 0, &nid);
> if (err < 0)
> return err;

other negative value would be odd here.

> err = hotadd_hidden_nodes(nid);
> if (err < 0)
> return err;

hotadd_hidden_nodes could return -EEXIST, which is also odd here, right?

> return count;
>
> Thanks,
> Fengguang



\
 
 \ /
  Last update: 2010-05-14 07:35    [from the cache]
©2003-2011 Jasper Spaans