lkml.org 
[lkml]   [2010]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC, 3/7] NUMA hotplug emulator
On Thu, May 13, 2010 at 09:55:11AM -0700, Greg KH wrote:
> On Thu, May 13, 2010 at 07:48:35PM +0800, Shaohui Zheng wrote:
> > Userland interface to hotplug-add fake offlined nodes.
>
> Why include 2 copies of the patch in one email?
I always try to attach the patch as attachment, it is the same with the mail
content, I guess it should take convenience when you need to save the patch
to local, it might be a bad habbit, I will be careful when I send patch next time.
thanks for the reminding.

>
> > Add a sysfs entry "probe" under /sys/devices/system/node/:
> >
> > - to show all fake offlined nodes:
> > $ cat /sys/devices/system/node/probe
> >
> > - to hotadd a fake offlined node, e.g. nodeid is N:
> > $ echo N > /sys/devices/system/node/probe
>
> As you are trying to add a new sysfs file, please create the matching
> Documentation/ABI/ file as well.

Agree, We will document it in.

>
> Also note that sysfs files are "one value per file", which I don't think
> this file follows, right?

Agree, the cpu/probe interface should write only, and we should create another
file to indicate the hidden nodes, such as cpu/hidden. We will follow this rule
when we send the formal patch.

Thanks greg's comments so much, have a nice day.

>
> thanks,
>
> greg k-h

--
Thanks & Regards,
Shaohui



\
 
 \ /
  Last update: 2010-05-14 03:53    [from the cache]
©2003-2011 Jasper Spaans