Messages in this thread | | | Date | Thu, 13 May 2010 17:54:39 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [linux-pm] Is it supposed to be ok to call del_gendisk while userspace is frozen? |
| |
On Thu, 13 May 2010, Matt Reimer wrote:
> So how does the attached patch look? > > Matt > > > From 20d8340471eb05aa54af1349f4ddccecd9c230c6 Mon Sep 17 00:00:00 2001 > From: Matt Reimer <mreimer@sdgsystems.com> > Date: Thu, 13 May 2010 14:36:54 -0700 > Subject: [PATCH] fs: prevent hang on suspend/resume when MMC/SD card present > > Devices can come and go from the MMC/SD bus during suspend or resume, > when the writeback thread is frozen, resulting in a hang. So thaw the > writeback thread in del_gendisk() to prevent the hang.
I don't see anything wrong with the patch itself, but I dislike the description. Devices can come and go from any hotpluggable bus, not just MMC/SD. That just happens to be the first place the problem was observed.
Alan Stern
| |