lkml.org 
[lkml]   [2010]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 0/10] Uprobes v3
From
Date
On Thu, 2010-05-06 at 23:31 +0530, Srikar Dronamraju wrote:
> - Addressed comments from Oleg, including removal of interrupt context
> handlers, reverting background page replacement in favour of
> access_process_vm().


> +static int write_opcode(struct task_struct *tsk, unsigned long vaddr,
> + user_bkpt_opcode_t opcode)
> +{
> + int ret;
> +
> + if (!tsk)
> + return -EINVAL;
> +
> + ret = access_process_vm(tsk, vaddr, &opcode, user_bkpt_opcode_sz, 1);
> + return (ret == user_bkpt_opcode_sz ? 0 : -EFAULT);
> +}

Why!

That's not not the atomic sequence outlined.



\
 
 \ /
  Last update: 2010-05-12 10:08    [W:0.139 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site